lerni

width & height is back on img-tag - in short chrome 79? & ff 71 will respect those values for aspect ratios on load (calculating layout) https://www.youtube.com/watch?v=4-d_SoCHeWE

I wonder what best practice now is - baseline or progressive images (jpgs)? Duno if this is even a thing with webp?

Show 1 attachment(s)
YouTube  
Mozilla Developer

YouTube Video: Do This to Improve Image Loading on Your Website

Hide attachment content
👍 (1)
mark.b

@nightjarnz I had done that and still don’t get the anchor link for the holder as shown in the top code taken copy from page source on the browser, the second code show how it should be in end

🙂 (1)
nightjarnz

@mark.b as per your example $Breadcrumbs(20, false, false, true) - try instead $Breadcrumbs(20, false, true, true) https://github.com/silverstripe/silverstripe-cms/blob/4/code/Model/SiteTree.php#L877

Show 1 attachment(s)
GitHub  
silverstripe/silverstripe-cms

SilverStripe CMS - this is a module for SilverStripe Framework rather than a standalone app. Use https://github.com/silverstripe/silverstripe-installer/ to set this up. - silverstripe/silverstripe-cms

Hide attachment content
mark.b

If I add a loop to the Bradcrumbs.ss template this is what I get, no breadcrumbs passed through

thats4shaw

I can’t see how it’s working based of your template snippet. I’d encourage you to look at vendor/silverstripe/cms/templates/BreadcrumbsTemplate.ss to see what I mean by not looping anything.

mark.b

@thats4shaw it works but just can’t see the holder page, only home / page and but not home / holder / page I had just read if I do $breadcrumbs(20, false, false, true) I can see see all the breadcrumbs but the holder don’t have an anchor to go back to that page

thats4shaw

Well that’s not going to work as you aren’t looping through anything.