nicolaas

they may have wanted to implement PSR-2 rules about variable style (i.e. camelCase)

nicolaas

no, I hear ya - it was probably not inteded to be a config setting - but there is no explanation why it should not be ....

nightjarnz

but, I could be wrong. You've opened an issue, that's all we can do :)

nightjarnz

OK. What I'm trying to say here is I do not think this is intended to be a config setting.

nicolaas

yeah - why not make it the same as all the other configs?

nightjarnz

Signs hint to it not being a config option though.

  1. Name is camelCase, not snake_case (snake_case is convention for configs)
  2. there are getters and setters
  3. it is not documented @config https://github.com/silverstripe/silverstripe-cms/blob/4/code/Model/SiteTree.php#L310-L313
Show 4 attachment(s)
code/Model/SiteTree.php:310-313

    /**
     * This controls whether of not extendCMSFields() is called by getCMSFields.
     */
    private static $runCMSFieldsExtensions = true;
code/Model/SiteTree.php:310-313

    /**
     * This controls whether of not extendCMSFields() is called by getCMSFields.
     */
    private static $runCMSFieldsExtensions = true;
code/Model/SiteTree.php:310-313

    /**
     * This controls whether of not extendCMSFields() is called by getCMSFields.
     */
    private static $runCMSFieldsExtensions = true;
code/Model/SiteTree.php:310-313

    /**
     * This controls whether of not extendCMSFields() is called by getCMSFields.
     */
    private static $runCMSFieldsExtensions = true;
Hide attachment content
nicolaas

I lodged an issue ... https://github.com/silverstripe/silverstripe-cms/issues/2389

Show 1 attachment(s)
sunnysideup

self::$runCMSFieldsExtensions needs to be changed to $this->config()->get('run_cms_fields_extensions') ???

Hide attachment content
nightjarnz

IF it is intended to be a config setting (refer to docs) then it should be $this->config()->get('run_cms_fields_extensions')

nightjarnz

@nicolaas No, that's the way to access a private static variable.

null

It will work, it's just not configurable I think. One of the core devs might be able to comment?