Message of the day:
Welcome. Latest release: https://www.silverstripe.org/download Community Forum: https://forum.silverstripe.org Features: https://forum.silverstripe.org/c/feature-ideas Archive: https://slackarchive.silverstripe.org
If you have any SilverStripe related questions, please supply the version of Framework you're using.
Did you flush? 🚽 =
Archive temporarily at https://archive.codingplayground.nl (redirect)
Hi I just updated an older site to SS4.6, I am having difficulty setting up date range filtering on a ModelAdmin page, anyone has done hat before?
might be worth it against SS4, which seems to retain the same method without a default value
Not read the scroll back (because I can't be assed), but If you do a PR against 3.x it MAY be possible to upmerge the change into 4.x branches
If it is only one method (and the class isn't too different between 3.x and 4.x)
in this case the method is identical between SS3 and SS4 - it’s just changing a param to have a default value
Might be OK, I have done similar on files with lots of differences, as long as git has a pretty clear list of changes to the file, it should be pretty seamless...
at this point it’s not even worth a PR against SS3
That is for the powers that be to decide I guess 🙂
it makes sense for the functionality to exist, I just think the default action should be to add the
DISTINCT clause without requiring the param
perhaps a module is returning a
DISTINCT list and you want to get the original duped list again
why would the distinct ever be false if the default call is false?
should at least default to true (because how often do you really need to remove a
DISTINCT clause using the ORM)