clodeindustrie

Hi I just updated an older site to SS4.6, I am having difficulty setting up date range filtering on a ModelAdmin page, anyone has done hat before?

Joe

might be worth it against SS4, which seems to retain the same method without a default value

Mo

Not read the scroll back (because I can't be assed), but If you do a PR against 3.x it MAY be possible to upmerge the change into 4.x branches

😂 (1)
Mo

If it is only one method (and the class isn't too different between 3.x and 4.x)

Joe

in this case the method is identical between SS3 and SS4 - it’s just changing a param to have a default value

Mo

Might be OK, I have done similar on files with lots of differences, as long as git has a pretty clear list of changes to the file, it should be pretty seamless...

Joe

at this point it’s not even worth a PR against SS3

r3v3rb

That is for the powers that be to decide I guess 🙂

Joe

it makes sense for the functionality to exist, I just think the default action should be to add the DISTINCT clause without requiring the param

Joe

perhaps a module is returning a DISTINCT list and you want to get the original duped list again

r3v3rb

why would the distinct ever be false if the default call is false?

Joe

should at least default to true (because how often do you really need to remove a DISTINCT clause using the ORM)