kinglozzer

Bobby 😂

dorsetdigital

Could have been worse. Some of the placeholder error messages I use are much less polite 🙂

andante

ahah @flamerohr merged his own PR! an advert for PR if i’ve ever seen one

dorsetdigital

Bobby is polite, I was saying that when I use placeholders for errors, they usually aren't 😉

flamerohr

I'm missing way too much context for this tag

kinglozzer

https://github.com/silverstripe/silverstripe-asset-admin/issues/916 this is the context 😛

Show 1 attachment(s)
jcop007

Max file number validation message is returning "Bobby" rather than a meaningful message.

https://github.com/silverstripe/silverstripe-asset-admin/blob/1.3.1/code/Forms/UploadField.php#L324|https://github.com/silverstripe/silverstripe-asset-admin/blob/1.3.1/code/Forms/UploadField.php#L324

public function validate($validator)
{
$maxFiles = $this->getAllowedMaxFileNumber();
$count = count($this->getItems());
if ($maxFiles < 1 || $count <= $maxFiles) {
return true;
}
$validator->validationError($this->getName(), _t('', 'Bobby'));
return false;
}

Hide attachment content
flamerohr

I think it was because a team member reviewed it and he didn't have merge rights - so I went "ok, as long as you're ok with it" and went 🤷‍♂️ :merge: !

firesphere

That deserves a pin/highlight or whatever for the rest of life

flamerohr

I'm just laughing that it's a week short from being in for a year 😂 (git blaming myself)


Show less replies
kinglozzer

https://github.com/silverstripe/silverstripe-asset-admin/issues/916

Show 1 attachment(s)
jcop007

Max file number validation message is returning "Bobby" rather than a meaningful message.

https://github.com/silverstripe/silverstripe-asset-admin/blob/1.3.1/code/Forms/UploadField.php#L324|https://github.com/silverstripe/silverstripe-asset-admin/blob/1.3.1/code/Forms/UploadField.php#L324

public function validate($validator)
{
$maxFiles = $this->getAllowedMaxFileNumber();
$count = count($this->getItems());
if ($maxFiles < 1 || $count <= $maxFiles) {
return true;
}
$validator->validationError($this->getName(), _t('', 'Bobby'));
return false;
}

Hide attachment content
LiamC

has anyone intergrated google shopping in SS? is it best to do a dev/task or use the RSS rendering? I have products and grouped products

Frontiex

Hey all, any one have any idea what this error is about? Trying to open a ModelAdmin in the CMS:

Files: Requires logging in to the Slack workspace to view/download
Pasted image at 2019-02-22, 4:21 PM (PNG)
danaenz

You can take out the Banners owns but leave the Image owns

mmativ

Like this, or i can safely remove the private static $owns = [ ‘Banners’ ];

Files: Requires logging in to the Slack workspace to view/download
Untitled (PHP)
mmativ

Hi, do i still need to add object to my owns even that object dont use Versioned::class, so my image will be published?