View more context

 

nightjarnz

ps. Probably don't toy with OS religion wars in a topical channel (or like, ever... ;P )

zanderwar

can u phix mah code:

  1. SELECT
  2. f_account.f_account_name,
  3. f_account.f_account_name,
  4. v_shipping.v_shipping_address2,
  5. v_shipping.v_shipping_address,
  6. v_shipping.v_shipping_address2,
  7. v_shipping.v_shipping_address2,
  8. f_invoice.f_invoice_issue_date,
  9. f_invoice.f_invoice_id,
zanderwar

i mean it removes duplicates automatically but god damn, imagine the rest of the 1800 lines of code in this file...

wmk

@zanderwar time for refactoring or at least some calesthenics?

zanderwar

the person who wrote this, didn't use any framework or anything just all raw mysqli_* queries, and he's created this massive PDF by referencing row fields by their integer key (0,1,2,3,4 etc) except the table has been modified massively, so some keys that the script references don't even exist anymore.

zanderwar
Files: Requires logging in with Slack to view/download
image.png