View more context


Hi all, https://github.com/silvershop/silvershop-core/blob/master/src/ORM/FieldType/ShopCurrency.php lacks proper casting for negative values. When I do a PR, is it enough to cast "Nice", or do I also need to cast all methods that can return Nice(), like NiceOrEmpty?

Attachments:
src/ORM/FieldType/ShopCurrency.php

I'm currently updating a SilverShop to SS4. Due to file versioning and old content OrderItem doesn't show the latest Image, as the Product was published some time ago and the Images got versioned recently during the update to SS4. Anyone has an idea how to fix this?

Seems I need to update the file version table...

well, just trying to figure that out per SQL... is tricky, when one image is used by more products...

I tend to keep it simple and just set files "last edited" to created...

then it's older than the latest product version before the update

  1. UPDATE File_Versions fv
  2. RIGHT JOIN SilverShop_Product_Versions pr ON (fv.RecordID = pr.ImageID AND pr.ImageID > 0)
  3.  
  4. SET LastEdited = Created;