View more context

 

Mo

@kinglozzer I am getting Indirect modification of overloaded property SilverCommerce\TaxAdmin\Tests\Model\TestProduct::$extension_instances has no effect

kinglozzer

That’s weird… I don’t know what might be overloading it 😬

Mo

Ah, the event hook itself is added by an extension, that might cause issues

Mo

Basically I want to test this extension hook: https://github.com/silvercommerce/tax-admin/blob/1.0/src/extensions/PricingExtension.php#L191

Show 1 attachment(s)
GitHub  
silvercommerce/tax-admin

Adds generic admin for managing tax rates via siteconfig - silvercommerce/tax-admin

Hide attachment content
kinglozzer

Hmm, looking at Extensible I guess you’re not really supposed to modify extension_instances directly anyway… so perhaps it’s not such a good idea even if you can get it working