View more context

 

nightjarnz

sitetree_table_localised haha, but why though? :> The variable is more chars than the actual name, and is static anyway (never reassigned).

nightjarnz

seems like a better use of params in any case :)

taoceanz

It's dynamically created the be set to the current locale so ends up like SiteTree_Localised_en_US or SiteTree_Localised_zh_cmn. I'd prefer not to repeat SiteTree_Localised_{$current_locale} multiple times.

  1. $current_locale = FluentState::singleton()->getLocale();
  2. $sitetree_table_localised = "SiteTree_Localised_{$current_locale}";
taoceanz

Hey Dylan, for future reference, many of us feel like we need to be light in our opinions about someone else or their work as to not hurt their feelings. Just fyi, I'm not fussed what your thoughts are on my questions or code so long as you explain why. If you think my code is junk, I'm not fused so long as you explain why it's so bad and what could be done to improve it. Don't feel you need to send emoji smiley faces on my account when critiquing me. If that makes sense.

taoceanz

Same goes for anyone critiquing me. Growth is achieved through truth.

nightjarnz

I certainly don't mean to offend, for sure. Smiley is there partly from habit, partly to show that I don't mean offence, and partly to acknowledge that this point has absolutely nothing to do with the code actually working or not.

nightjarnz

I understand that sharing code isn't easy sometimes, though either fear of judgement, NDAs, client confidentiality, IP security, etc. I normally ask if something I spot that seems illogical is out of context - sometimes I forget though. Assumption make an ass, etc.

phyzical

@nightjarnz na thats what i was thinking, i feel like its being over-engineered. but meh wwaht do i know

nightjarnz

I often like to say when I feel like I'm not qualified to judge, and am only offering a suggestion. Clarity pays dividends I've found over my years helping folks out like this.