@Firesphere Did you end up making any advances into an ElasticSearch compat layer in
silverstripe-solr-search? I vaguely remember you talking about that. Obviously going to be a leaky abstraction, but on the
addField() level we could make it compatible. Just brainstorming at the moment, don’t get too spooked 😄
Aside: Elastic App Search looks quite nice from a dev/author/user/ops perspective, although I don’t really see a way to get from A to B on our platforms in a way that doesn’t double up all our efforts (and basically do everything half as good heh).
Not yet, I've been a bit swamped by people emailing me to "just fix stuff", which took my motivation to do any dev work well and truly away
Hah, that … sounds familiar!
@Julius has joined the channel
@muskie9 has joined the channel
I've updated Solr Search to use the BufferedAdd plugin. If anyone has a really, like, seriously large dataset to test it with, please do so?
More info here: https://github.com/Firesphere/silverstripe-solr-search/pull/130
Use Buffered Add instead of building the buffer ourself Still include the option to use a group Add a commit at the end I'm not just making this PR for HacktoberFest You rock. Thanks a lot.Hide attachment content
If anyone is interested, here's the "scope" of the FTS API surface, which is way too massive. I've marked it as "won't fix" because I don't believe the API surface should be that big. But, if anyone wants to, a module extending my base compatibility module that covers (some/most) of this, is fine with me https://github.com/Firesphere/silverstripe-solr-compatibility/issues/2
I've taken a look at over 100 distinct implementations of fulltextsearch to see how inclusive this compatibility module is and where some of the sharp edges will be in practical application of ...Hide attachment content
Note that I do not want or expect a PR covering all the "open" issues, because I do not feel that they should even exist in the first place.
I might accept a few. Note that some methods have moved to a different place instead of actually being gone. Or some things might seem unused, while they are not actually unused due to traits 🙂