View more context

 

nicolaas

Well, this code: $this->$key = $value is executed well before it gets to write ... by executed I do not mean send to the DB.

Firesphere

But, like I said, don't blindly trust me 😄

nicolaas

I am wondering if you could end up with code being executed like this: $this->nothing; do something bad here; where $key = 'nothing; do something bad here;'

nicolaas

something bad: print_r(file_get_contents('../../../.env'));

robjingram

Anyone finding that invalid @return types in doc blocks are breaking the PHP language server in VScode? I think the PHP documentor crashes on return types such as File[]

nightjarnz

I don't think I've noticed that, but I have noticed that the phpstan plugin gets very very very upset about things like that.

nightjarnz

eg. return null <- phpstan: NULL IS NOT A STRING! 😠

robjingram

The documentor error is similar. It complains that the return types should implement an interface but it is getting null

null

My name is a string though

❤️ (1)