robbieaverill

React form fields are usually designed for the cms only. It might work, but you’d need to BYO React app and probably use injector (decoupled POC for frontend available on request) in order to make it work

robbieaverill

hey team, if anyone wants to pick up a UX issue in one of the supported modules or core, and wants to find an easy issue to get started with (e.g. CSS changes or JS tweaks), here's a list which should be a good start: https://silverstripe-github-issues.now.sh/?mode=easy&q=label%3Achange%2Fpatch+label%3Atype%2Fbug+label%3Atype%2Fux

(2)
robbieaverill

I have a suspicion that advancedworkflow is what needs to be modified. some examples have come up from that patch where modules or project code are writing non scalars to DataObject properties and have got away with doing it in the past, but maybe need to change now. I think I answered a question on StackOverflow about this recently too... https://stackoverflow.com/questions/54975814/how-to-load-json-into-field-of-silverstripe-dataobject - an example of an unintended side effect from that patch, while the patch is actually doing exactly what it should be doing

Show 2 attachment(s)
Stack Overflow  
How to load JSON into field of Silverstripe Dataobject

A recent Silverstripe version upgrade to 4.3.1 appears to have broken some functionality where a dataobject is loaded as JSON into a Textfield. The object looks like this: class Foo extends DataO...

Stack Overflow  
How to load JSON into field of Silverstripe Dataobject

A recent Silverstripe version upgrade to 4.3.1 appears to have broken some functionality where a dataobject is loaded as JSON into a Textfield. The object looks like this: class Foo extends DataO...

Hide attachment content
robbieaverill

the code for that is pretty well covered with unit tests, so if you have a failing test and can make a patch that fixes it while keeping the rest of the framework tests green, i'd say go for it with a pull request. if it's related to that issue I'd say probably 3.6 is the right branch to target, but we can always suggest a branch change once the PR is open 👍

👍 (1)
robbieaverill

👋 Hi everyone, we at SilverStripe want to have a focussed place where we can help you with any questions you have around contributing to the SilverStripe core and official module ecosystem, so we've started up a new channel #get-involved for that purpose. Jump in if you want to find good issues to start hacking on, have questions about how to make issues, pull requests, unit tests, rebasing, running yarn build etc - feel free to ping one of the SilverStripe team members in the channel with any questions (no promises about prompt responses, but we'll be watching the channel! 👀).

🎉 (1)
robbieaverill

👋 Hi everyone, we at SilverStripe want to have a focussed place where we can help you with any questions you have around contributing to the SilverStripe core and official module ecosystem, so we've started up a new channel #get-involved for that purpose. Jump in if you want to find good issues to start hacking on, have questions about how to make issues, pull requests, unit tests, rebasing, running yarn build etc - feel free to ping one of the SilverStripe team members in the channel with any questions (no promises about prompt responses, but we'll be watching the channel! 👀).