robbieaverill

yeah we updated to php7 a year or so ago but it's probably time to jump to 8 now 😄

👍 (1)
robbieaverill

not all repos have been migrated to xenial yet, so some may still use trusty as the default when you don't specify one

robbieaverill

i think we need to move away from using number_format in the currency logic in silverstripe soon, in order to support proper i18n for currencies. not sure if that get rid of this problem but it sounds like it would. relevant thread: https://github.com/silverstripe/silverstripe-framework/issues/8216

Show 1 attachment(s)
GitHub  
Currency DBField doesn't allow setting different thousands & decimals separators · Issue #8216 · silverstripe/silverstripe-framework

Affected Version 3., 4. Description In some locales, currencies use different separators, eg in Dutch (Netherlands) we use '€1.000,00' (as opposed to '$1,000.00'). The Currency fiel...

Hide attachment content
👍 (1)
robbieaverill

They may even make it into SS4, nothing is breaking, we just needed to use that as a polyfill module for older SS versions although haven’t actually made the core PRs yet though 😆

👍 (1)