robbieaverill

I have a suspicion that advancedworkflow is what needs to be modified. some examples have come up from that patch where modules or project code are writing non scalars to DataObject properties and have got away with doing it in the past, but maybe need to change now. I think I answered a question on StackOverflow about this recently too... https://stackoverflow.com/questions/54975814/how-to-load-json-into-field-of-silverstripe-dataobject - an example of an unintended side effect from that patch, while the patch is actually doing exactly what it should be doing

Show 2 attachment(s)
Stack Overflow  
How to load JSON into field of Silverstripe Dataobject

A recent Silverstripe version upgrade to 4.3.1 appears to have broken some functionality where a dataobject is loaded as JSON into a Textfield. The object looks like this: class Foo extends DataO...

Stack Overflow  
How to load JSON into field of Silverstripe Dataobject

A recent Silverstripe version upgrade to 4.3.1 appears to have broken some functionality where a dataobject is loaded as JSON into a Textfield. The object looks like this: class Foo extends DataO...

Hide attachment content
robbieaverill

the code for that is pretty well covered with unit tests, so if you have a failing test and can make a patch that fixes it while keeping the rest of the framework tests green, i'd say go for it with a pull request. if it's related to that issue I'd say probably 3.6 is the right branch to target, but we can always suggest a branch change once the PR is open 👍

👍 (1)
robbieaverill

👋 Hi everyone, we at SilverStripe want to have a focussed place where we can help you with any questions you have around contributing to the SilverStripe core and official module ecosystem, so we've started up a new channel #get-involved for that purpose. Jump in if you want to find good issues to start hacking on, have questions about how to make issues, pull requests, unit tests, rebasing, running yarn build etc - feel free to ping one of the SilverStripe team members in the channel with any questions (no promises about prompt responses, but we'll be watching the channel! 👀).

🎉 (1)
robbieaverill

👋 Hi everyone, we at SilverStripe want to have a focussed place where we can help you with any questions you have around contributing to the SilverStripe core and official module ecosystem, so we've started up a new channel #get-involved for that purpose. Jump in if you want to find good issues to start hacking on, have questions about how to make issues, pull requests, unit tests, rebasing, running yarn build etc - feel free to ping one of the SilverStripe team members in the channel with any questions (no promises about prompt responses, but we'll be watching the channel! 👀).

robbieaverill

👋 Hi everyone, we at SilverStripe want to have a focussed place where we can help you with any questions you have around contributing to the SilverStripe core and official module ecosystem, so we've started up a new channel #get-involved for that purpose. Jump in if you want to find good issues to start hacking on, have questions about how to make issues, pull requests, unit tests, rebasing, running yarn build etc - feel free to ping one of the SilverStripe team members in the channel with any questions (no promises about prompt responses, but we'll be watching the channel! 👀).

👍 (1)
robbieaverill

👋 Hi everyone, we at SilverStripe want to have a focussed place where we can help you with any questions you have around contributing to the SilverStripe core and official module ecosystem, so we've started up a new channel #get-involved for that purpose. Jump in if you want to find good issues to start hacking on, have questions about how to make issues, pull requests, unit tests, rebasing, running yarn build etc - feel free to ping one of the SilverStripe team members in the channel with any questions (no promises about prompt responses, but we'll be watching the channel! 👀).

robbieaverill

https://github.com/dnadesign/silverstripe-elemental/blob/master/docs/en/upgrading_to_4.md

Show 1 attachment(s)
docs/en/upgrading_to_4.md

# Upgrading from Elemental 3 to 4

Version 4 of Elemental introduces some breaking changes which developers should be aware of.

These changes have been made in order to support Elemental transitioning from a PHP GridField based CMS interface into
a React JavaScript interface using the [SilverStripe GraphQL](<https://github.com/silverstripe/silverstripe-graphql/>) API
as the backend. The data model and relationships remain largely the same.

## Notable changes

### ElementalEditor and GridField

`ElementalEditor` no longer exists. Types of blocks that can be edited are now defined on the field 
(`ElementalAreaField`) itself. You can get an `ElementalAreaField` by creating one directly:

```php
use DNADesign\Elemental\Forms\ElementalAreaField;
use DNADesign\Elemental\Models\ElementContent;

$area = $page-&gt;ElementalArea();
$allowedElements = [ElementContent::class];
$field = ElementalAreaField::create('editor', $area, $allowedElements);

ElementalAreaField still extends GridField but this is only used to provide a GridFieldDetailForm. In order to customise components of the elemental editor in the CMS, developers must now use the JavaScript Injector and apply React higher order components to transform the behaviour of individual components.

For more information, see here.

ElementalArea and SiteTree

All SiteTree instances now have the elemental SiteTreeExtension extension applied (regardless of where you apply ElementalPageExtension), in order to provide a consistent API surface for accessing the associated ElementalArea (required for GraphQL queries). Developers using more ElementalArea relations than the default will need to add similar extensions, as well as augment the GraphQL query at client/src/state/editor/readBlocksForPageQuery.js.

Hide attachment content