Ryan

Seems to not strip out site CSS 😂

nightjarnz

Which part is affected by site CSS @Ryan? - I seem to recall think it did strip site CSS... but could be bad memory.

null

I've noticed on my OSX installs at home, the login-forms module always seems to default to dark mode

Ryan

@nightjarnz It seems to still be loading in the CSS I add with Requirements

null

Doesn't do it at work using Ubuntu browsers

null

It doesn't bother me too much, I just assumed I was doing something dumb and haven't bothered to troubleshoot 😛

null

I have no idea if I have done that. I do prefer it, so maybe 😄

nightjarnz

@Ryan it still extends PageController iirc, so this is probably why. We did discuss making it not extend PageController (which is default Security behaviour that was just carried over), but don't think we got there yet.

null

I don't think it should extend PageController, because that assumes you have SiteTree records

nightjarnz

I think there are some settings you can do with Config in order to control some of the things. Don't recall what exactly though from the top of my head. Just remember adding them.

null

I have it installed on a headless app now, so I don't think it requires PageController

nightjarnz

It depends if you deem log in form as "site domain" or "CMS domain".

nightjarnz

You're logging in to the CMS. But you're logging in to the admin area of SITE. So ... yeah.

null

I can imagine the CMS product team sitting around one afternoon, reminiscing about the wonderful things SS2 used to do 😛

nightjarnz

There's some minor customisation you can do to the login-forms module that will allow enough recognition of which site you're trying to get into.

Ryan

@nightjarnz I would say that it should reflect the site design, but be separate to ensure the client understands the context switch.

nightjarnz

if you use an SVG logo you can also make it do the darkmodes stuff.

nightjarnz

@Ryan yeah, this is kinda long the same lines of "Do I use themes or do I use app/templates?"

Ryan

Maybe I should just try harder to get `

  1. Requirements::clear();

working

nightjarnz

This is basically the crux of it all: https://github.com/silverstripe/silverstripe-login-forms/blob/4/src/EnablerExtension.php#L50

Show 1 attachment(s)
GitHub  
silverstripe/silverstripe-login-forms

Login form templates for SilverStripe CMS. Contribute to silverstripe/silverstripe-login-forms development by creating an account on GitHub.

Hide attachment content
nightjarnz

It's a pretty simple module, I'm sure you can find feets in there :>

nightjarnz

it's simply a theme over the "standard" log in form.

Ryan

19th of December essentially drills down to: "Behold! The field in which I grow my fucks. Lay thine eyes upon it and thou shalt see that it is barren."

🤣 (1) ✔️ (1)
nightjarnz

Summer is a bad time for growing things @Ryan - it's now nearly a month later and my field is still in the same state :/

😂 (1)
null

I have travelled the North Island for several weeks also looking for @Ryan’s field of fucks, and was not successful

👍 (1)

Show less replies
Ryan

I want to remove my own module that styles the login forms.

Ryan

Does the recipe-cms 4.5 have the security form styling?

Ryan

Just did a composer update and 4.5 was added. I don't see anything about it being released?